Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotten Ingredient Check #28250

Closed
SolsticeTheTechMarine opened this issue Feb 18, 2019 · 6 comments
Closed

Rotten Ingredient Check #28250

SolsticeTheTechMarine opened this issue Feb 18, 2019 · 6 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid.

Comments

@SolsticeTheTechMarine
Copy link

Is your feature request related to a problem? Please describe.
Occasionally if I am not paying attention to the massive stack of random ingredients I have acquired, I will get a rotten meal out of whatever recipe I create.

Describe the solution you'd like
I would propose a check for the ingredients to see if any are rotten. If rotten ingredients are detected, it should ask if you are sure you wish to continue creating the meal, just as one would be asked before jumping into a pit.

Describe alternatives you've considered
Other alternatives would be to exclude rotten material all together, but I don't think that would be great for certain recipes.

@Night-Pryanik Night-Pryanik added Info / User Interface Game - player communication, menus, etc. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 18, 2019
@Zireael07
Copy link
Contributor

I believe this (or a form of this) has been suggested multiple times?

@Night-Pryanik
Copy link
Contributor

Yes, but I couldn't find the exact issue.

@codemime
Copy link
Contributor

One of the corresponding issues is #25382.

@Ilysen
Copy link
Contributor

Ilysen commented Feb 22, 2019

I went and took a look at this to try and figure it out, but my coding skills aren't up-to-snuff enough to figure it out. It seems as though the crafting doesn't actually recognize that the individual items exist; just that items of that type exist. The crafting system doesn't differentiate between 3 rotten chunks of fat on the ground and 2 frozen chunks of fat in a minifreezer - it just counts it as "5 nearby chunks of fat."

It seems like the easiest thing to do would be to exclude rotten ingredients, since it could just override the check to make sure that rotten food items aren't included in the list of valid ingredients if the result has a spoilage timer, but that could cause problems in of itself.

I'm sure that this is doable, but I don't know how...

@stale
Copy link

stale bot commented Aug 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 9, 2019
@stale
Copy link

stale bot commented Sep 8, 2019

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

5 participants