Cannot use some hotkeys to choose tank to fill in a vehicle

[Zetsukaze]

Describe the bug
Some hotkeys can be used to select tanks, while others cannot. I have observed this on previous builds but only confirmed this for the current build.

To Reproduce
Steps to reproduce the behavior:

1. Have a vehicle with a few tanks
2. Examine the vehicle to bring up the vehicle screen, press [f] to refill a tank
3. Press [g] or [h] and observe nothing happens
4. Press [c] or [d] and observe that the screen to choose which liquid to fill appears

Expected behavior
All the hotkeys shown work

Screenshots

Versions and configuration(please complete the following information):
Windows 10, Build 8097

[kevingranade]

This is handled here

Cataclysm-DDA/src/veh_interact.cpp

Line 1246 in fffed0b

bool veh_interact::overview( std::function<bool( const vehicle_part &pt )> enable,

I'm guessing this little lambda

Cataclysm-DDA/src/veh_interact.cpp

Lines 1272 to 1278 in fffed0b

	const auto next_hotkey = [&]( char &hotkey ) {
	hotkey += 1;
	if( hotkey == '{' ) {
	hotkey = 'A';
	}
	return hotkey;
	};

needs to skip over reserved keybindings.

[chrimchim]

Hello, I am an amateur coder looking to work on the project with my only experience being the free Codecademy C++ course I completed to try to learn more about it. I've been looking at this problem for a couple days and I can't see an easy way to tell which keys are bound and which aren't. I tried looking at the main inventory's code for a solution but that is in many ways more complicated and uses a lot of dependencies. I would greatly appreciate any info on where to look for solutions or where this problem is fixed in other parts of the game as I continue to figure this out.

[Ramza13]

This looks like its been fixed but not closed.