Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't milk a robot, others #25519

Open
SunshineDistillery opened this issue Sep 10, 2018 · 5 comments
Open

Can't milk a robot, others #25519

SunshineDistillery opened this issue Sep 10, 2018 · 5 comments
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.

Comments

@SunshineDistillery
Copy link
Contributor

Describe the bug
As far as I can see, there are three ways a monster can be friendly: being defined as belonging to the player's faction (slimespring), becoming flagged as a pet (cow), being flagged as controlled (turrets presumably). These three friendlies don't have the same behavior. A trait like milking is available for a tamed creature, but a milkable robot can only be turned off.

To Reproduce
Feed a cow and release a manhack. "e"xamining them brings up different menus/options.

Expected behavior
One 'friendly' state and a standard menu for interacting with them. Monster traits, like milking, to work consistently no matter how the monster was tamed or deployed.

Versions and configuration:

  • OS: Windows 7
  • Game Version: 7619
  • Graphics version: Tiles
  • Mods loaded: None/ testing mods

Additional context
By itself, a pretty inconsequential problem, but there are other things like putting a bag on a robot or tying a robot to a leash that could be useful. Things like the flag PET_WONT_FOLLOW doesn't work on deployed grenade-hacks, which would be really nice.

@ItsJustAlexC
Copy link
Contributor

uhhhh what

@ItsJustAlexC
Copy link
Contributor

ItsJustAlexC commented Sep 10, 2018

no offense but, I've read this over 2 times, and besides the friendly units mechanic, this seems very nonsensical

@kevingranade
Copy link
Member

It's a infrastructure issue that is impacting ability to do modding I think. The feature ask is that no matter how a creature gets a "tamed" flag, they can be treated the same way with respect to interactions.

@SunshineDistillery
Copy link
Contributor Author

Yeah, exactly. There are several 'friendly' states, but there should be one. Currently, useful features for pets don't apply to turrets/robots just because those monsters are spawned from items.

Obviously, milking a robot is silly, but I thought I could hijack the feature to mod robots to produce mutagen or other chemicals. From there I discovered a few other issues resulting from having separate flags.

@mlangsdorf mlangsdorf added Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 11, 2018
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed and removed <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 3, 2019
@scorpion451
Copy link

scorpion451 commented Jan 22, 2020

This is a brilliant idea that would open up a ton of potential, needs suggestion and interface flags too, maybe game mechanics change as well.

Kevin's comment nails it- a single interaction window for all friendly states, that dynamically generates interactions based on flags. (and ideally a single friendly state as well)

Say, I'm a modder and I create a robot that produces clean water. I give it a "HARVESTLIQUID" flag, and indicators that it produces clean water, how much, and how fast, and the appropriate fluff text for "milking" it. Said robot also has a flag that it can be hitched, so the option to tie it in place appears in the list. I want this robot to work as a carrier, too, so I flag it as being a valid target for saddlebags or a backpack.

Another robot has the ability to mount weapons, so a flag gives it the menu option for giving it a weapon. NPCs also have this flag, for easy weapon swapping.

I have a spider NPC follower. They get "HARVESTITEM" flag with the web rope production mutation, so I can interact with them to have them produce some rope or thread for me.

All friendly creature interactions go through this same menu, everything is dynamically generated based on flags, totally plug-and-play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

No branches or pull requests

6 participants