Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair inconsistency leading to huge exploits #24803

Open
FulcrumA opened this issue Aug 12, 2018 · 5 comments
Open

Repair inconsistency leading to huge exploits #24803

FulcrumA opened this issue Aug 12, 2018 · 5 comments
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced Game: Mechanics Change Code that changes how major features work Vehicles Vehicles, parts, mechanics & interactions

Comments

@FulcrumA
Copy link
Contributor

Game version: 0.C-30348

Operating system: Win7

Tiles or curses: Tiles

Mods active: More Survival Tools, Stats Through Skill, Vehicle Additions Pack, Tanks and Other Vehicles, Boats, Icecoon's Arsenal, Filthy Clothing, Makeshift Items Mod, More Buildings, No Flaming Weapons, Disable NPC Needs, No Antique Firearms, No Fictional Guns, NPC Traits, Extended Realistic Guns.

Expected behavior

Vehicle parts and items can be repaired on the basis of same rules and requirements.

Actual behavior

Many vehicle parts have different requirements when repaired as items using soldering irons/welders and when installed as part of vehicles. Some items require glue or other such things in one case but can be easily soldered/welded in the other. Additionally, vehicle-installed parts require absolutely no resources to repair beyond charges of the welder while repairing same parts by hand uses plastic/metal (usually in form of scrap). Some items can be only repaired while disconnected from the vehicle, others only when installed.

Repair data for every item/part should be held by the part entry and all attempts to repair such should consult this single particular place. Otherwise one way of repairing things is clearly and unfairly superior than the other.

@HeadWar
Copy link

HeadWar commented Aug 12, 2018

For extra credit, make vehicle repair use the same principle as other repairs, with a percentage chance of success or damage, and multiple attempts, rather than just a fixed time to automatically repair.

@Night-Pryanik Night-Pryanik added Game: Mechanics Change Code that changes how major features work Vehicles Vehicles, parts, mechanics & interactions labels Aug 12, 2018
@CoroNaut
Copy link

If this goes through then all items should probably be able to have the reinforced tag meaning that all vehicle parts could be reinforcable which would be fantastic.

@rubenpd
Copy link

rubenpd commented Aug 14, 2018

also repairing a military composite ram requires 3 mechanics, repairing a military composite armor plating require 5, and you build both parts with same spare part

@Asmageddon
Copy link
Contributor

@HeadWar What about setting repair time to expected repair time, rather than fully random, as a compromise, e.g. if it's 10% chance to repair and 1m per attempt, set it to 10m, or to the ~6.6m that are expected on average.

But alas, basing vehicle part repair on underlying item repair, would be a really sizeable change to make.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 10, 2019
@kevingranade kevingranade added the <Bug> This needs to be fixed label Aug 10, 2019
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Aug 10, 2019
@wapcaplet wapcaplet added the <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced Game: Mechanics Change Code that changes how major features work Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

No branches or pull requests

8 participants