Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt to activate a light source in response to light-level crafting interrupt #23971

Closed
smolbird opened this issue Jun 8, 2018 · 10 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Suggestion / Discussion> Talk it out before implementing

Comments

@smolbird
Copy link
Contributor

smolbird commented Jun 8, 2018

See discussion in #23944

To summarize, the code is able to recognize transforming items, and when the player tries to sleep it is also able to prompt the player and warn about active items.

Suggestion is thus: when declining light level leads to a crafting interruption, instead of halting the task and counting on the (bugged, not readily apparent to the player, finicky) resume crafting feature, instead ask the player if they would like to activate a light source.

If so, they pick a valid item (looks for transform and an adequate light output) and continues crafting, If player declines, or if no valid items are in the crafting radius, crafting interrupts as per current behavior.

Reasoning is that the player should not have to turn on a light source when it's bright out just to prevent crafting interruption, instead they should only be prompted to activate a light source when it becomes necessary during the process of crafting.

@DracoGriffin DracoGriffin added <Suggestion / Discussion> Talk it out before implementing Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jun 8, 2018
@FulcrumA
Copy link
Contributor

FulcrumA commented Jun 9, 2018

Should search for all light sources in player's close vicinity, like how it is with looking for ingredients for crating. Possibly turn off those light sources after crafting. I'd also expand it to fuel for cooking devices - if someone is using survivor mess kit, for example, and there's lamp oil nearby, a popup asking to fuel the kit with nearby oil and continue cooking would be good (suggesting here since it's something that could use suggested system).

@Night-Pryanik
Copy link
Contributor

It would be a big work. What if there is several types of light sources available? Flashlight, oil lamp, electric lamp, dying out bonfire and what else.

@FulcrumA
Copy link
Contributor

FulcrumA commented Jun 9, 2018

I think current system could be easily repurposed - attempting to craft a thing lists possible ingredients in the area if there are several alternatives and the fueled devices that can be used to prepare them if there are several eligible.

@Brambor
Copy link
Contributor

Brambor commented Jun 9, 2018

Bionics should be used as well. There is cardinal flashlight CBM that should be listed in possible light sources. (please)

@FulcrumA
Copy link
Contributor

FulcrumA commented Jun 9, 2018

Yeah, cranial flashlight could work too. Cardinal less so, unless you have a clergyman NPC willing to hold it for you.

@smolbird
Copy link
Contributor Author

Should search for all light sources in player's close vicinity

Agreed, as noted in the OP I did say crafting radius.

It would be a big work. What if there is several types of light sources available? Flashlight, oil lamp, electric lamp, dying out bonfire and what else.

Prompt should show a list, and activate the one that the player chooses.

@DracoGriffin
Copy link
Contributor

Prompt should show a list, and activate the one that the player chooses.

Should also default to the player's previous selection (instead of the player having to have more keypresses to reach the same option) -- or at least a list prompt with choice hotkeys like rebinding hotkeys and talking to NPCs has.

@kevingranade
Copy link
Member

Fixed by #24077

@kevingranade
Copy link
Member

My bad that's wrong, this is a bigger but still valid request.

@ifreund
Copy link
Contributor

ifreund commented Apr 5, 2019

Due to inactivity and the fact that resuming will be much more reliable after the referenced PR, making this issue mostly void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

7 participants