Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquiring missions momentarily freezes the game or fails mission initialization, depending on world options for city #21950

Closed
lucianposton opened this issue Sep 21, 2017 · 4 comments
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Missions Quests and missions stale Closed for lack of activity, but still valid.

Comments

@lucianposton
Copy link
Contributor

lucianposton commented Sep 21, 2017

Game version: 8a96896

Operating system: linux

Tiles or curses: tiles

Mods active:
1 "dda",
2 "More_Survival_Tools",
3 "Urban_Development",
4 "boats",
5 "filthy_morale",
6 "more_locations",
7 "no_npc_food",
8 "novitamins",
9 "realguns"

Expected behavior

Either a notification that the mission is being generated or don't hang.

Actual behavior

Hangs at 100% cpu usage for a variable amount of time on my desktop with i7 @ 4GHz. Sometimes it will hang for 3 seconds. Other times, it hangs for nearly a full minute and "Unable to place all configured specials, some missions may fail to initialize." is added to the message log. See

add_msg( _( "Unable to place all configured specials, some missions may fail to initialize." ) );

Steps to reproduce the behavior

  • Create new character in shelter
  • Increasing "Size of cities" and "City spacing" world options seems to exacerbate the issue to the point that missions consistently fail to initialize.
  • Accept mission from terminal in shelter
@kevingranade
Copy link
Member

The mission in question is probably important, some missions kick off a search for a building, which is probably what is causing the delay.

@kevingranade kevingranade added the Code: Performance Performance boosting code (CPU, memory, etc.) label Sep 21, 2017
@ituluwituluwzev ituluwituluwzev added the Missions Quests and missions label Sep 21, 2017
@lucianposton
Copy link
Contributor Author

lucianposton commented Sep 22, 2017

I started a new character in a new world and picked up the terminal mission. This time the game hung for nearly a full minute.

For this world, the Size of cities was 8 and City spacing was 8. Perhaps that makes it more difficult to find a suitable location to place the mission.

edit: I was able to reproduce the issue again with another new world with those same world options set to 8. Added this info to issue description.

Anything over 6 for these options causes missions to fail initialization.

@lucianposton lucianposton changed the title Game hangs momentarily when accepting a mission Game hangs momentarily when accepting a mission, sometimes failing initialization Sep 22, 2017
@lucianposton lucianposton changed the title Game hangs momentarily when accepting a mission, sometimes failing initialization Missions momentarily freeze the game or fail initialization depending on world options for city Sep 22, 2017
@lucianposton lucianposton changed the title Missions momentarily freeze the game or fail initialization depending on world options for city Acquiring missions momentarily freezes the game or fails mission initialization, depending on world options for city Sep 22, 2017
@Night-Pryanik
Copy link
Contributor

Should this be closed after #28959?

@stale
Copy link

stale bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Missions Quests and missions stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

4 participants