Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capoeira "Hit all adjacent monsters" does not work properly #1950

Closed
3t3rn4lfl4m3 opened this issue Jul 6, 2013 · 4 comments
Closed

Capoeira "Hit all adjacent monsters" does not work properly #1950

3t3rn4lfl4m3 opened this issue Jul 6, 2013 · 4 comments

Comments

@3t3rn4lfl4m3
Copy link

I have experimented a little with Capoeira and encountered some issues when the "spin-kick" kills monsters. This was tested in "Version: 0.6-116-gd1d6525"

  1. The game only counts the primary target in kills. Or perhaps the spin-kick is only applied to the other targets and you attack the primary target normally.
  2. Spin-kick erases stuff from existence. Monsters killed by spin-kicks do not leave any loot or even a corpse.

Though it is not a bug, why is "Hit all adjacent monsters" in the category of "Other Offensive Techniques" rather than "Crit-only Offensive Techniques"? If your primary attack is a critical hit, the game does not roll for a spin-kick, but rather checks if a "Sweep Attack" is made. It makes no sense to make the unique attack of a martial art style less likely as unarmed skill increases.

@ejseto
Copy link
Contributor

ejseto commented Jul 6, 2013

I just opened a pull request to fix 2. a few hours ago. The game only picks one technique to apply no matter what. In that sense, yes, as your skill goes up and you crit more, you will start having crit techniques displace your spin kick. Putting spin kick in "Crit-only Offensive Techniques" would not change this. "Other Offensive Techniques" are always placed in the technique selection vector while "Crit-only Offensive Techniques" are only placed there if you crit. From this vector, only 1 technique is ever selected (completely at random).

Hmm, actually you're right, it doesn't fill the vector with non-crit techniques if you have a crit technique in the vector.

@KA101
Copy link
Contributor

KA101 commented Jul 7, 2013

At least you've seen the spin/sweeps. I've never seen them happen at all. Glad to hear they exist, at least.

@ianestrachan
Copy link
Contributor

Does this work now? The WIDE flag was re-implemented with the latest martial arts changes.

@kevingranade
Copy link
Member

If I update the styles to have a wide attack it seems to work, but none of them have a wide attack at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants