Consistency in exiting menus

[ifreund]

The new menu that pops up when examining a toilet gives options to drink the liquid or pour it on the ground. However, unlike other menus in the game it has no cancel option. I think this should be added to be consistent with other menus, such as butchering or repairing clothing.

[mugling]

Try escape key, this is consistent with many other menus

[ifreund]

I know that escape key works, I'm just saying that q for cancel should work as well

[mugling]

That behavior would cause problems in menu's that assign hotkeys based upon invlets (as q and c are both valid invlets). Esc doesn't have this problem

[ifreund]

Then, for consistency, would it make more sense to remove the q cancel option from butchering and repairing? Or replace it with Esc cancel on all menus?

[mugling]

Yes, I think we should aim for consistency and using Esc guarantees no conflicts with existing hotkeys (however they are allocated)

[ifreund]

So moving forward, should we just remove the cancel option from menus that currently have it? Or replace it with ⎋? (I know that is unicode not ascii so that would be annoying.) If we remove the cancel option would it be unclear how to exit a menu without choosing a listed option?

[illi-kun]

Particular case of #12112.