-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting items into backpacks without changing the inventory screen. #16650
Comments
This would be pretty much unmaintainable, a total hack that would break more often than not. |
I realize that it would need special coding to be made to act like furniture, trash can was just a good example of what it would act like. I didn't mean to just turn it straight up into furniture. Doing that would make it so that you couldn't pick it up anyways, right? And don't we have most of those properties in foldable carts already? I mean, I don't think we should turn bags into vehicles or nothing (unless the vehicle menu is hidden somehow). I'm just saying there's got to be some way to do it. |
A map tile can contain pretty much only items and one piece of each of: terrain, furniture, trap.
No, foldable carts are just vehicles that can become items when interacted with, then turned back into vehicles when used as items. This wouldn't be usable with bags due to number of keypresses to do anything. The problem here is the UI. There is a lot to be done to make it usable and so far no one did it. The bags on the ground would have to stay items. Not furniture or hacks like that. |
Why wouldn't just dropping them into the top most bag work? Then if the bag gets filled it drops off onto other adjacent tiles, like if the tile was full? Then there wouldn't need to be a UI. What do you mean by automatic repacking? That sounds fun. |
One of the primary reasons to have items in bags is dropping a worn bag with all its contents to fight easier, then picking it back up all at once. This requires tracking which items are in which bag. It wouldn't be acceptable to require the player to manually pick which items are in which bag.
|
Duplicate of #3671 |
See, I was thinking there would need to be no changes at all to the inventory screen. So when you pick a bag up, all you get is the benefit of not picking the bag and all the stuff up all one at a time. And when you drop a bag and other stuff, all you get is the benefit of not having to spend the time dropping the bag and all the other stuff. That is how it is not a duplicate of anything, and why Kevin agreed that it was a good idea on IRC. No minutia of having to do anything at all with bags in your inventory, but all the good parts of being able to drop stuff and pick stuff up quick. |
Well, the issue name clearly implies a duplicate. At least change that. |
Awesome, thanks Coolthulhu. |
This still isn't a good description. Though it would be better if you split it into 2 separate issues:
|
Okay. Would the filling the bags up on the ground go in the second issue, do you think? |
The first. The second one wouldn't really touch the mechanics at all, only the time to pickup and time to drop. |
Thanks so much, Coolthulhu. I really appreciate your time and expertise on this. |
The way this could work is if containers dropped along with other items had
the other items added to their internal contents. Drop code would need to
make this change, pickup code would need to reverse it, and look around
code would need to describe it differently.
|
I'm currently working on the drop code (will PR a WIP soon), but my current intention is simplifying it gradually, so that adding new features (and fixing bugs like #14035) would become easier. Adding something to its original (non-refactored) implementation would be pretty much a hack. |
I would like to suggest (and I ran it past Kevin on IRC) that backpacks, duffle bags, suitcases, MOLLE packs, etc, turn into furniture when they are dropped, so you can fill them up, and grab them and drag them around.
Also, it would be cool, if it was made to just cost how much time it takes to put on the backpack, instead of picking all the items up individually.
Same with multi dropping it and other items, it could say, "Do you want to keep the additional items in the bag? Y/N/Q" even if the items weren't in the bag to begin with.
This idea need not, in any way, change the inventory screen as it is currently.
More than one bag a tile, only the top bag should be fillable. Or maybe bags should slip off other bags, like if the tile is full?
The text was updated successfully, but these errors were encountered: