Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: starting city destruction #10316

Closed
ogoid opened this issue Dec 3, 2014 · 10 comments
Closed

Suggestion: starting city destruction #10316

ogoid opened this issue Dec 3, 2014 · 10 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@ogoid
Copy link

ogoid commented Dec 3, 2014

Isn't funny that the vehicles start damaged, but the towns neat and clean?

How about creating new worlds with some broken windows and doors, collapsed buildings, trash, blood and other signs of earlier chaos?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Shoes01
Copy link
Contributor

Shoes01 commented Dec 3, 2014

I think vache was working on something like that a long time ago. I get angry when I try and understand the mapgen code, so I can understand if he has yet to complete his PR.

@kevingranade
Copy link
Member

Definitely something we'd like to see, a good way to do this would be a
method in the master mapgen function that randomly applies some different
effects to submaps after generation.
An even cooler thing I've been trying to figure out would be to patch
something into both overmapgen and mapgen to apply large-scale
modifications to a swath of several submaps. During overmap generation, it
would pick a number of contiguous tiles to apply an effect to and mark
them. During mapgen, if it generates a tile with such a feature, it would
trigger loading of the connected subsmaps, then apply post-processing to
all of them.
The specific hook would go in map::load, if it detects the submap hasn't
been generated, it can check if the submap is marked for a feature, if so
it would trigger loading a map with dimensions equal to the size of the
feature, and then it could operate on that map as a whole.
Examples of large scale features: a very large bomb crater that overlaps
submap boundaries. A long stretch of rubber laid down on a road, with a
car wreck at the end.

@KA101 KA101 added the <Enhancement / Feature> New features, or enhancements on existing label Dec 3, 2014
@kevingranade kevingranade added the (S2 - Confirmed) Bug that's been confirmed to exist label Dec 8, 2014
@sparr
Copy link
Member

sparr commented Mar 21, 2015

a method in the master mapgen function that randomly applies some different effects to submaps after generation.

I don't know where it is, but don't we already have this? I've seen lava cracks in random buildings, and large areas of rubble, etc.

@Rivet-the-Zombie
Copy link
Member

Yeah, but Vache's plan was for buildings to sometimes have blood/damage on them, broken windows/doors, smashed furniture, being partially burned, stuff like that.

We'd likely have it already if not for the fact that the PR got bogged down by the addition of a bunch of similar, but unnecessary other stuff, like pre-triffidized buildings and such.

@kevingranade
Copy link
Member

kevingranade commented Mar 21, 2015 via email

@sparr
Copy link
Member

sparr commented Mar 21, 2015

I'm confused. I swear I saw a garage with a lava fissure through it, and I assumed "add a lava fissure" was an overlay somewhere.

@Zireael07
Copy link
Contributor

Umm, linky to vache's PR? I know which one is being discussed here, but can't find it, search is not up to par.
I'm sure Coolthulthu or acidia could restart the idea in a cleaner way :)

@Rivet-the-Zombie
Copy link
Member

The original PR in question: #7892

@MattAmmann
Copy link
Contributor

@sparr The lava spawning inside buildings is a map extra. I actually had this same question not too long ago: #11393

@drbig drbig added the (P5 - Long-term) Long-term WIP, may stay on the list for a while. label Jul 15, 2015
@illi-kun
Copy link
Contributor

This issue was closed as it appears inactive.

Reducing open issues to those which are (or will) be actively worked upon helps us focus our efforts. This issue has not been deleted - it still appears in searches and if it contains relevant information you are encouraged to continue to link to it.

If this issue was a bug

It should be reopened if it can be reproduced in the current build. You can obtain the most recent copy here. Please check there is not a more recent report of this bug before doing so. If no more recent report exists you should continue the discussion in this issue.

If this was a feature request

If the consensus was that the idea was good you could consider submitting an implementation via a PR. If you want to comment further please do so here as opposed to opening a new issue. Before posting check nobody has already made the same point and consider whether your comments are likely to lead to an implementation. If you have doubts about either consider instead voting for the issue

If you want to work on this issue

Then either assign it to yourself or if you are unable to do so claim it via adding a comment. Please don't assign others or make a general request for action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

10 participants