From c54a89a88c7e47bb8c7c94da518459cbdc86b60f Mon Sep 17 00:00:00 2001 From: CV514 Date: Tue, 27 Apr 2021 14:45:17 +0600 Subject: [PATCH] Magiclysm NPC mission dialogue fix NPC were assigned TALK_MISSION_OFFER instead of TALK_MISSION_LIST, and while it works for accepting their jobs, it doesn't provide necessary function for them to say that they don't have any more jobs for the player, resulting in `assign_mission: mission_selected == nullptr` Except for old magus, who has necessary checks, but I've changed them too in case of future updates with more quests added. --- data/mods/Magiclysm/npc/TALK_HEALER_GREY.json | 2 +- data/mods/Magiclysm/npc/TALK_OLD_MAGUS.json | 2 +- data/mods/Magiclysm/npc/TALK_TECHNO_KID.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/data/mods/Magiclysm/npc/TALK_HEALER_GREY.json b/data/mods/Magiclysm/npc/TALK_HEALER_GREY.json index 1ed139ca09f89..d10254b5097bf 100644 --- a/data/mods/Magiclysm/npc/TALK_HEALER_GREY.json +++ b/data/mods/Magiclysm/npc/TALK_HEALER_GREY.json @@ -18,7 +18,7 @@ }, { "text": "Wanna get outta here?", "topic": "TALK_SUGGEST_FOLLOW" }, { "text": "Let's trade items.", "topic": "TALK_HEALER_GREY", "effect": "start_trade" }, - { "text": "Can I do anything for you?", "topic": "TALK_MISSION_OFFER" }, + { "text": "Can I do anything for you?", "topic": "TALK_MISSION_LIST" }, { "text": "About the mission…", "topic": "TALK_MISSION_INQUIRE", "condition": "has_assigned_mission" }, { "text": "About one of those missions…", diff --git a/data/mods/Magiclysm/npc/TALK_OLD_MAGUS.json b/data/mods/Magiclysm/npc/TALK_OLD_MAGUS.json index 5ee961b6072d0..a427701c14779 100644 --- a/data/mods/Magiclysm/npc/TALK_OLD_MAGUS.json +++ b/data/mods/Magiclysm/npc/TALK_OLD_MAGUS.json @@ -20,7 +20,7 @@ { "text": "Let's trade items.", "topic": "TALK_OLD_MAGUS", "effect": "start_trade" }, { "text": "Can I do anything for you?", - "topic": "TALK_MISSION_OFFER", + "topic": "TALK_MISSION_LIST", "condition": { "and": [ { "not": "has_assigned_mission" }, diff --git a/data/mods/Magiclysm/npc/TALK_TECHNO_KID.json b/data/mods/Magiclysm/npc/TALK_TECHNO_KID.json index a7c3bca0822d6..cdf6a546a3df9 100644 --- a/data/mods/Magiclysm/npc/TALK_TECHNO_KID.json +++ b/data/mods/Magiclysm/npc/TALK_TECHNO_KID.json @@ -18,7 +18,7 @@ }, { "text": "Wanna get outta here?", "topic": "TALK_SUGGEST_FOLLOW" }, { "text": "Let's trade items.", "topic": "TALK_TECHNO_KID", "effect": "start_trade" }, - { "text": "Can I do anything for you?", "topic": "TALK_MISSION_OFFER" }, + { "text": "Can I do anything for you?", "topic": "TALK_MISSION_LIST" }, { "text": "About the mission…", "topic": "TALK_MISSION_INQUIRE", "condition": "has_assigned_mission" }, { "text": "About one of those missions…",