From 0bb3e86467248a73d7c93904eb5858012b496e49 Mon Sep 17 00:00:00 2001 From: John Bytheway <52664+jbytheway@users.noreply.github.com> Date: Sun, 19 Mar 2023 02:12:41 -0400 Subject: [PATCH] Set OSX_MIN on CI to match release workflow (#64364) To avoid bugs appearing in release builds that were not detected on CI, update the CI build script to use the same OSX_MIN value as release builds. See for example #64314 which was such an issue. --- build-scripts/gha_compile_only.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build-scripts/gha_compile_only.sh b/build-scripts/gha_compile_only.sh index c75576c9219a9..f9cb303c4aca3 100755 --- a/build-scripts/gha_compile_only.sh +++ b/build-scripts/gha_compile_only.sh @@ -62,7 +62,10 @@ then .. make -j$num_jobs else - make -j "$num_jobs" RELEASE=1 CCACHE=1 CROSS="$CROSS_COMPILATION" LINTJSON=0 + # The OSX_MIN version here should match that used in release builds so that + # CI detects issues that will affect releases. It doesn't affect builds on + # other platforms. + make -j "$num_jobs" RELEASE=1 CCACHE=1 CROSS="$CROSS_COMPILATION" LINTJSON=0 OSX_MIN=10.12 fi # vim:tw=0