From 86918a26ca1aca999ddd7be1111029328fe64f41 Mon Sep 17 00:00:00 2001 From: ClementTsang Date: Wed, 27 Apr 2022 17:59:19 -0400 Subject: [PATCH] bug: change as_ref calls so rust beta 1.61 builds For context, see: - https://github.com/ClementTsang/bottom/issues/708 - https://github.com/rust-lang/rust/issues/96074 This changes the calls from `as_ref()`, which was causing type inference issues, to just `as_slice()` which works fine. --- CHANGELOG.md | 9 +++++++++ src/canvas.rs | 8 ++++---- src/canvas/dialogs/dd_dialog.rs | 13 +++++-------- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cae17847a..c238a7bc6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.6.9] / [0.7.0] - Unreleased +## Bug Fixes + +- [#711](https://github.com/ClementTsang/bottom/pull/711): Fix building in Rust beta 1.61 due to `as_ref()` calls + causing type inference issues. + +## Changes + +- [#690](https://github.com/ClementTsang/bottom/pull/690): Adds some colour to `-h`/`--help` as part of updating to clap 3.0. + ## Features - [#676](https://github.com/ClementTsang/bottom/pull/676): Adds support for NVIDIA GPU temperature sensors. diff --git a/src/canvas.rs b/src/canvas.rs index 447d94215..217b68a82 100644 --- a/src/canvas.rs +++ b/src/canvas.rs @@ -627,7 +627,7 @@ impl Painter { if self.derived_widget_draw_locs.is_empty() || app_state.is_force_redraw { let draw_locs = Layout::default() .margin(0) - .constraints(self.row_constraints.as_ref()) + .constraints(self.row_constraints.as_slice()) .direction(Direction::Vertical) .split(terminal_size); @@ -648,7 +648,7 @@ impl Painter { )| { izip!( Layout::default() - .constraints(col_constraint.as_ref()) + .constraints(col_constraint.as_slice()) .direction(Direction::Horizontal) .split(draw_loc) .into_iter(), @@ -659,7 +659,7 @@ impl Painter { .map(|(split_loc, constraint, col_constraint_vec, col_rows)| { izip!( Layout::default() - .constraints(constraint.as_ref()) + .constraints(constraint.as_slice()) .direction(Direction::Vertical) .split(split_loc) .into_iter(), @@ -669,7 +669,7 @@ impl Painter { .map(|(draw_loc, col_row_constraint_vec, widgets)| { // Note that col_row_constraint_vec CONTAINS the widget constraints let widget_draw_locs = Layout::default() - .constraints(col_row_constraint_vec.as_ref()) + .constraints(col_row_constraint_vec.as_slice()) .direction(Direction::Horizontal) .split(draw_loc); diff --git a/src/canvas/dialogs/dd_dialog.rs b/src/canvas/dialogs/dd_dialog.rs index b6bda9de5..14e33354e 100644 --- a/src/canvas/dialogs/dd_dialog.rs +++ b/src/canvas/dialogs/dd_dialog.rs @@ -376,14 +376,11 @@ impl KillDialog for Painter { // Now draw buttons if needed... let split_draw_loc = Layout::default() .direction(Direction::Vertical) - .constraints( - if app_state.dd_err.is_some() { - vec![Constraint::Percentage(100)] - } else { - vec![Constraint::Min(3), Constraint::Length(btn_height)] - } - .as_ref(), - ) + .constraints(if app_state.dd_err.is_some() { + vec![Constraint::Percentage(100)] + } else { + vec![Constraint::Min(3), Constraint::Length(btn_height)] + }) .split(draw_loc); // This being true implies that dd_err is none.