Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from rabbitpy to a maintained client library such as pika #313

Closed
thomas-touhey opened this issue Mar 16, 2023 · 1 comment
Closed

Comments

@thomas-touhey
Copy link
Contributor

thomas-touhey commented Mar 16, 2023

What action do you want to perform

Update pytest-rabbitmq to use a maintained client library such as pika instead of rabbitpy.

What are the results

rabbitpy hasn't been updated on PyPI since 2019 (4 years ago!) and does not work with 3.x releases of pamqp:

>>> from rabbitpy import Exchange, Queue, Connection
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/thomas/.cache/pypoetry/virtualenvs/teal-sCn2En4E-py3.11/lib/python3.11/site-packages/rabbitpy/__init__.py", line 24, in <module>
    from rabbitpy.connection import Connection
  File "/home/thomas/.cache/pypoetry/virtualenvs/teal-sCn2En4E-py3.11/lib/python3.11/site-packages/rabbitpy/connection.py", line 17, in <module>
    from rabbitpy import base
  File "/home/thomas/.cache/pypoetry/virtualenvs/teal-sCn2En4E-py3.11/lib/python3.11/site-packages/rabbitpy/base.py", line 13, in <module>
    from pamqp import specification
ImportError: cannot import name 'specification' from 'pamqp' (/home/thomas/.cache/pypoetry/virtualenvs/teal-sCn2En4E-py3.11/lib/python3.11/site-packages/pamqp/__init__.py)

This is blocking when using aio-pika or aioamqp, official clients with asyncio supports from rabbitmq.com's list, which require pamqp >=3.1.

What are the expected results

Being able to use pytest-rabbitmq with referenced asyncio compatible libraries for RabbitMQ. For this, we need to have a library that supports recent releases of pamqp. rabbitmq.com recommends pika.

@thomas-touhey thomas-touhey changed the title Switch from rabbitpy to pika Switch from rabbitpy to a maintained client library such as pika Mar 16, 2023
@fizyk fizyk closed this as completed in dcd96a4 May 10, 2023
@thomas-touhey
Copy link
Contributor Author

Thank you so much @kropatwakrzysztof @fizyk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants