Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed behaviour: change of cmake kit doesn't change build folder name. ( doesn't copy patterns from global config ). #179

Closed
Arniiiii opened this issue Dec 14, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Arniiiii
Copy link

Arniiiii commented Dec 14, 2023

Bug description

Changed behaviour with a last update:

  • change of cmake kit doesn't change build folder.

Steps to reproduce

Minimal configuration
  1. Set in global config for the plugin cmake_build_directory = "build/${kit}/${kitGenerator}/${variant:buildType}",
  2. Before:
    • switch kit ( i.e. was gcc v13. now clang v16 )
    • new dir in build ( was build/GCC ...v13//Debug/... , + new folder build/Clang ...v16//Debug/... )
    • there's results with another kit in another folder ( i.e. in build/Clang ...v16//Debug)
  3. Now:
    • switch kit
    • no new dir ( what's interesting it seems it saves path not in ~/.cache/cmake_tools_nvim/pathtoproject.lua, because I can't explain why it saves the value no matter deleting session file in the mentioned folder)
    • yep, kit is changed, though build dir name is not ( using the same folder. i.e. continuing using gcc's build folder, instead of clang )

Expected behavior

One of the following:

  • document the behaviour
  • "return" behaviour.

if return behaviour, there's maybe such solution:

  • by default, copy pattern from global config's cmake_build_directory to session's settings build_options
  • allow it to be expanded by all of this. ( It seems to work already ! )
  • maybe add capability of copying of the pattern ( if it existed before in the session settings build_options ) when :CMakeSelectBuildDir

Screenshots

Environment

  • OS: a linux with neovim v0.9.4 and LuaJIT 2.1.1700008891
  • Desktop environment: KDE
  • Plugins commit hash: 6c248e1

Additional context

@Arniiiii Arniiiii added the bug Something isn't working label Dec 14, 2023
@Arniiiii Arniiiii changed the title Changed behaviour: change of cmake kit doesn't change build folder ${kit}. Changed behaviour: change of cmake kit doesn't change build folder name. ( doesn't apply pattern ${kit} and maybe other). Dec 14, 2023
@Arniiiii Arniiiii changed the title Changed behaviour: change of cmake kit doesn't change build folder name. ( doesn't apply pattern ${kit} and maybe other). Changed behaviour: change of cmake kit doesn't change build folder name. ( doesn't copy patterns from global config ). Dec 14, 2023
@Civitasv
Copy link
Owner

See comment: #176 (comment)

@Arniiiii
Copy link
Author

Hm... I didn't changed it, though, it seemed it didn't work. IDK why, and sorry for the misleading.

Maybe it's possible to put somehow pattern string when :CMakeSelectBuildDir ?
Now :
image

@Civitasv
Copy link
Owner

Pushed a fix.

@Civitasv
Copy link
Owner

Closing for now, feel free to open it if you still have this problem.

@Arniiiii
Copy link
Author

It seems to work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants