Dev sync ago #5
Open
Dev sync ago #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-M-Waldman
requested changes
Mar 4, 2024
sync-ago.py
Outdated
| username='maps.phl.data', | ||
| password=MAPS_PASSWORD, | ||
| ago_creds = citygeo_secrets.connect_with_secrets(connect_maps_ago, "maps.phl.data") | ||
| org = GIS(url=ago_creds.get('url'), |
There was a problem hiding this comment.
This should be refactored into a connection function that is passed to citygeo_secrets in the connect_with_secrets method in order to leverage the packages' functionality of trying again with secrets from the keeper api if the first connection attempt fails using secrets from the mapped drive.
sync.py
Outdated
| sf = Salesforce(username=SF_USER, \ | ||
| password=SF_PASSWORD, \ | ||
| security_token=SF_TOKEN) | ||
| sf = Salesforce(username=salesforce_creds.get('login'), \ |
There was a problem hiding this comment.
Same as above; this should leverage citygeo-secrets by using refactoring the Salesforce connection into a function that is passed to the connect_with_secrets method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get credentials from keeper using citygeo_secrets