Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using ListingFilterParams on the frontend #625

Closed
Tracked by #63
avaleske opened this issue Sep 22, 2021 · 0 comments · Fixed by #626
Closed
Tracked by #63

Stop using ListingFilterParams on the frontend #625

avaleske opened this issue Sep 22, 2021 · 0 comments · Fixed by #626
Assignees
@avaleske
Labels
epic: filtering Tickets related to Filtering size: 2 Half a day of work
Milestone
M12

Comments

@avaleske
Copy link

avaleske commented Sep 22, 2021 •
edited
Loading

ListingFilterParams is a backend filter state object, which includes things like the comparison to use, etc.

We initially started using it on the frontend to keep the frontend and backend in sync, but their uses have diverged. Now, we need a different storage object for the frontend filter state.
@avaleske avaleske mentioned this issue Sep 22, 2021
Closed
35 tasks
@avaleske avaleske self-assigned this Sep 22, 2021
@avaleske avaleske added the epic: filtering Tickets related to Filtering label Sep 22, 2021
@avaleske avaleske added this to the M12 milestone Sep 22, 2021
@avaleske avaleske added M12 size: 2 Half a day of work labels Sep 22, 2021
@avaleske avaleske mentioned this issue Sep 22, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avaleske avaleske

Labels
epic: filtering Tickets related to Filtering size: 2 Half a day of work
Projects
None yet
Milestone
M12
Development

Successfully merging a pull request may close this issue.

Decouple frontend filter state storage from ListingFilterParams CityOfDetroit/bloom
1 participant
@avaleske