Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer casting bug #524

Closed
Tracked by #63
avaleske opened this issue Sep 2, 2021 · 0 comments · Fixed by #529
Closed
Tracked by #63

Fix integer casting bug #524

avaleske opened this issue Sep 2, 2021 · 0 comments · Fixed by #529
Assignees
Labels
bug Something isn't working epic: filtering Tickets related to Filtering size: 2 Half a day of work
Milestone

Comments

@avaleske
Copy link

avaleske commented Sep 2, 2021

At

const hasAvailabilityColumnName = `LOWER(CAST(${filterTypeToFieldMap[filterType]} as text))`

it looks like we're casting an integer field to be a text field, and then doing an >= comparison on it.

We should fix this, so we do a numerical comparison instead of a lexicographic comparison.

@avaleske avaleske mentioned this issue Sep 2, 2021
35 tasks
@avaleske avaleske added epic: filtering Tickets related to Filtering size: 2 Half a day of work labels Sep 2, 2021
@avaleske avaleske added this to the M11 milestone Sep 2, 2021
@github-actions github-actions bot added the M11 label Sep 2, 2021
@avaleske avaleske added the bug Something isn't working label Sep 2, 2021
@avaleske avaleske self-assigned this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic: filtering Tickets related to Filtering size: 2 Half a day of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant