Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Size Filter #324

Closed
2 of 3 tasks
Tracked by #63
avaleske opened this issue Aug 4, 2021 · 3 comments · Fixed by #368, #388 or #391
Closed
2 of 3 tasks
Tracked by #63

Unit Size Filter #324

avaleske opened this issue Aug 4, 2021 · 3 comments · Fixed by #368, #388 or #391
Assignees
Labels
epic: filtering Tickets related to Filtering P0 Highest priority size: 5 A few days of work
Milestone

Comments

@avaleske
Copy link

avaleske commented Aug 4, 2021

Add filtering on unit size.

Steps:

  • Add to backend
  • Contribute backend changes upstream (Under Review)
  • Add to frontend (Under Review)

Per Tom's comment below:

  • Should be in a single dropdown
  • Should have radio options of Studio +, 1 Bedroom +, 2 Bedrooms +, 3 Bedrooms +, 4 Bedrooms +. This will maximize the amount of results returned for the user.
  • In a future phase we may want to add an option for "Show only exact match," which would constrain the results specifically to the user's selection and ignore the "+"
@avaleske avaleske mentioned this issue Aug 4, 2021
35 tasks
@avaleske avaleske changed the title Unite Size Filter Unit Size Filter Aug 4, 2021
@avaleske avaleske self-assigned this Aug 4, 2021
@avaleske avaleske added blocked by question Work is blocked by an open question epic: filtering Tickets related to Filtering M9 P0 Highest priority size: 5 A few days of work labels Aug 4, 2021
@avaleske avaleske added this to the M9 milestone Aug 4, 2021
@avaleske
Copy link
Author

avaleske commented Aug 4, 2021

@kar-r-green and @tomgebauer lmk when we have mocks for how unit size filtering should work, assigning to @tomgebauer for now.

@tomgebauer
Copy link

I need to mock, but I'm having some Figma issues, so wanted to clarify

  • Should be in a single dropdown
  • Should have radio options of Studio +, 1 Bedroom +, 2 Bedrooms +, 3 Bedrooms +, 4 Bedrooms +. This will maximize the amount of results returned for the user.
  • In a future phase we may want to add an option for "Show only exact match," which would constrain the results specifically to the user's selection and ignore the "+"

@avaleske avaleske removed the blocked by question Work is blocked by an open question label Aug 4, 2021
@avaleske
Copy link
Author

avaleske commented Aug 4, 2021

Thanks! Unassigning you @tomgebauer and removing the blocked label

@avaleske avaleske linked a pull request Aug 11, 2021 that will close this issue
17 tasks
@avaleske avaleske reopened this Aug 11, 2021
@avaleske avaleske mentioned this issue Aug 11, 2021
15 tasks
@avaleske avaleske linked a pull request Aug 11, 2021 that will close this issue
15 tasks
@avaleske avaleske reopened this Aug 11, 2021
@avaleske avaleske linked a pull request Aug 11, 2021 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: filtering Tickets related to Filtering P0 Highest priority size: 5 A few days of work
Projects
None yet
2 participants