Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Polish #313

Closed
Tracked by #63
avaleske opened this issue Aug 3, 2021 · 2 comments
Closed
Tracked by #63

Pagination Polish #313

avaleske opened this issue Aug 3, 2021 · 2 comments
Assignees
Labels
epic: filtering Tickets related to Filtering size: 2 Half a day of work
Milestone

Comments

@avaleske
Copy link

avaleske commented Aug 3, 2021

Some fixes for the paginator:

  • Add number of pages to the paginator, so it shows "Page X of Y"
  • Next / Prev buttons are at the edges of the page on desktop, instead of at the edges of listing column container
  • Pagination maybe? should be sticky if multiple pages on desktop?
@avaleske avaleske mentioned this issue Aug 3, 2021
35 tasks
@avaleske avaleske added epic: filtering Tickets related to Filtering size: 2 Half a day of work labels Aug 3, 2021
@github-actions github-actions bot added the M12 label Aug 11, 2021
@willrlin willrlin added this to the M12 milestone Aug 12, 2021
@anders-schneider
Copy link

One more thing I discovered: when there are no items, the pagination bar doesn't look good:

image

(I got there by (a) logging into the partner portal, (b) clicking on a listing, (c) appending "/flags" to the url)

An idea: just get rid of the "page x of y" (but keep the "(0 total listings)")

@anders-schneider
Copy link

The last thing in this ticket: should the pagination bar be sticky on desktop view? I experimented with it (by just setting the sticky={true} param on the AgPagination component) and have a slight preference against it being sticky - it just "feels more natural" to me to have the "next / prev" at the bottom of the page. But I would love for someone else to have strong feelings in one direction or the other :)

I'll close this ticket, but invite anyone with pro-sticky-pagination-bar feelings to reopen (it'd be easy to implement, since the "sticky" CSS class has already been defined).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: filtering Tickets related to Filtering size: 2 Half a day of work
Projects
None yet
Development

No branches or pull requests

3 participants