Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make addFilter generic so we can contribute upstream #202

Closed
Tracked by #63
avaleske opened this issue Jul 16, 2021 · 0 comments · Fixed by #257
Closed
Tracked by #63

Make addFilter generic so we can contribute upstream #202

avaleske opened this issue Jul 16, 2021 · 0 comments · Fixed by #257
Assignees
@avaleske
Labels
epic: filtering Tickets related to Filtering size: 3 About a day of work
Milestone
M8

Comments

@avaleske
Copy link

avaleske commented Jul 16, 2021 •
edited
Loading

Per Sean's comments on addFilter() here we should make addFilter() generic.

If we refactor out the listings specific map so that it's provided by the caller, then other entities can use this filter logic too.

Once we do this, we can contribute filters upstream (#192)
@avaleske avaleske mentioned this issue Jul 16, 2021
Closed
35 tasks
@avaleske avaleske mentioned this issue Jul 16, 2021
Closed
4 tasks
@avaleske avaleske added epic: filtering Tickets related to Filtering size: 3 About a day of work labels Jul 16, 2021
@avaleske avaleske mentioned this issue Jul 16, 2021
Merged
23 tasks
@avaleske avaleske added this to the M8 milestone Jul 20, 2021
@avaleske avaleske added the M8 label Jul 20, 2021
@avaleske avaleske self-assigned this Jul 21, 2021
@avaleske avaleske mentioned this issue Jul 23, 2021
Merged
23 tasks
@avaleske avaleske linked a pull request Jul 23, 2021 that will close this issue
Update addFilter to take a map of filter type to field name #257
Merged
23 tasks
@avaleske avaleske mentioned this issue Jul 26, 2021
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avaleske avaleske

Labels
epic: filtering Tickets related to Filtering size: 3 About a day of work
Projects
None yet
Milestone
M8
Development

Successfully merging a pull request may close this issue.

Update addFilter to take a map of filter type to field name CityOfDetroit/bloom
1 participant
@avaleske