Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize Archer listing's use in tests #182

Closed
anders-schneider opened this issue Jul 13, 2021 · 0 comments
Closed

Rationalize Archer listing's use in tests #182

anders-schneider opened this issue Jul 13, 2021 · 0 comments
Labels
epic: dev velocity Misc tickets for improving dev velocity size: 2 Half a day of work

Comments

@anders-schneider
Copy link

anders-schneider commented Jul 13, 2021

We have a sample listing defined in ui-components/__tests__/fixtures/archer.json. It is used in a number of tests:

In some of these tests, the test itself defines UnitSummarys, which are intended to summarize the units that are defined in archer.json. In e.g. UnitTables.test.tsx, that summary comes with a note that it was "copied from listings service output", but I can't tell how to reproduce that output.

The units defined in archer.json and the unit summaries defined in the test could easily diverge, causing tests to fail in non-obvious ways. I'd propose that we either generate the summaries automatically (instead of defining them in the test) or explicitly define everything (the Archer listing and its summary) in the test itself.

@anders-schneider anders-schneider added epic: dev velocity Misc tickets for improving dev velocity size: 2 Half a day of work labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: dev velocity Misc tickets for improving dev velocity size: 2 Half a day of work
Projects
None yet
Development

No branches or pull requests

2 participants