Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detroit - Front End Scaffold Listings Finder #1422

Closed
kathyccheng opened this issue Aug 17, 2022 · 4 comments
Closed

Detroit - Front End Scaffold Listings Finder #1422

kathyccheng opened this issue Aug 17, 2022 · 4 comments

Comments

@kathyccheng
Copy link

kathyccheng commented Aug 17, 2022

As an engineer,
I might want to see how all of the components come together
So that I can start building out the questions from here

Acceptance Criteria

  • When I click on Find Listings for you on the Homepage, then I will see a screen that incorporates the Progress Bar, Form Card, Options, Skip and Next

Notes

  • Just front end scaffolding where possible
  • Mobile support
  • Detroit specific styling

Designs
https://www.figma.com/file/pIlN9vqLwUgOZYq6I5oM9l/bloom-public-eligibility-wizard?node-id=726%3A5778

image

image

Product Brief
https://docs.google.com/document/d/1KIECKEDJljxPq3l0PYRe-XerWdEDjqkf1KEm8e9-KeE/edit#heading=h.z2we68wtdnff

@slowbot
Copy link
Collaborator

slowbot commented Oct 19, 2022

@ColinBuyck

  • Next button retains focus as user moves between pages.
  • Focus should reset as user moves from page to page. Ideally this would bring the user to the start of the form content area

@slowbot
Copy link
Collaborator

slowbot commented Oct 25, 2022

A couple of things I found so far

  • The “Find Listings for You” element should be an h1
  • The step header should be a header of some level based on its placement in the reader order rather than just a div - in this case an h2
  • In the cases where the step header is used in conjunction with the progress nav I think you can lose the progress nav screen reader only header
  • The question inside the card should also have a heading level in this case I think we can use an h1 again if you switch the from card from an article to a section otherwise you can use an h3.
  • Can we update the containers for each set of form elements to use a fieldset with legend rather than a div?

@eajensenwa
Copy link
Collaborator

@ColinBuyck

Mobile updates

Card

Card left/right margins - 1rem/16px
Card header - 1.25rem/20px
Skip link - left align
Header

Progress bar - does not need to display on mobile
Page header vertical margins - 1.5rem/24px (let me know if this change is outside scope of these issues)

@eajensenwa
Copy link
Collaborator

@ColinBuyck LGTM You can go ahead and close out, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants