Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-by-one error in listings pagination #141

Closed
abbiefarr opened this issue Jul 4, 2021 · 0 comments · Fixed by #147
Closed

Off-by-one error in listings pagination #141

abbiefarr opened this issue Jul 4, 2021 · 0 comments · Fixed by #147
Assignees
Labels
bug Something isn't working

Comments

@abbiefarr
Copy link

I expect there's an off-by-one error somewhere in the pagination pipeline.

Example of expected behavior:
There are 7 total listings and we're supposed to display 2 per page. We expect 4 total pages, the first 3 holding 2 listings each, and the last page showing 1.

Actual behavior:
In the above example, only 3 pages are shown, each with 2 listings.
However, if we have 7 listings and we show at least 7 per page, all 7 listings show up on the first (and only) page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants