Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When fetching customer info from DVV, look up active permits from database #433

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

danjacob-anders
Copy link
Contributor

@danjacob-anders danjacob-anders commented Dec 7, 2023

PV-720

How Has This Been Tested?

Tested manually

Manual Testing Instructions for Reviewers

In admin UI:

  1. Create a permit for a user
  2. Create another permit for another vehicle. Prices should be adjusted for 2nd vehicle, and it should not be possible to change months

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d292ea0) 82.46% compared to head (a3e7607) 82.46%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #433   +/-   ##
========================================
  Coverage    82.46%   82.46%           
========================================
  Files          152      152           
  Lines         9381     9383    +2     
========================================
+ Hits          7736     7738    +2     
  Misses        1645     1645           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@mhieta mhieta merged commit 5c73b38 into develop Dec 7, 2023
5 checks passed
@mhieta mhieta deleted the PV-720-fetch-active-permits-on-customer branch December 7, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants