Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canBeRefunded to webshop GraphQL schema #432

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

danjacob-anders
Copy link
Contributor

@danjacob-anders danjacob-anders commented Dec 5, 2023

This uses property ParkingPermit.can_be_refunded, so we can check logic in frontend if a refund is needed when ending or editing a permit.

Context

PV-734

How Has This Been Tested?

Tested manually

Manual Testing Instructions for Reviewers

Create an open ended permit, starting immediately, high emission vehicle

Change to low emission vehicle

No refund preview page should be shown, redirects to permits page, no refunds handled in backend.

This uses property ParkingPermit.can_be_refunded, so we can check logic
in frontend if a refund is needed when ending or editing a permit.

Refs: PV-734
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhieta mhieta merged commit d292ea0 into develop Dec 5, 2023
5 checks passed
@mhieta mhieta deleted the PV-734-change-vehicle-refund-bugfix branch December 5, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants