Always validate permit_id existence

City-of-Helsinki · Sep 11, 2023 · f62398d · f62398d
1 parent 6355d4d
commit f62398d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/parking_permits/views.py b/parking_permits/views.py
@@ -554,6 +554,12 @@ def post(self, request, format=None):
             meta = validated_subscription_data.get("meta")
             meta_item = get_meta_item(meta, "permitId")
             permit_id = meta_item.get("value") if meta_item else None
+            if not permit_id:
+                logger.error("Permit id is missing from subscription meta data")
+                return Response(
+                    {"message": "No permit id is provided"},
+                    status=400,
+                )
 
             order_item_qs = OrderItem.objects.filter(
                 order__talpa_order_id=talpa_order_id,