Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL support to navigation component #392

Open
Jokinen opened this issue Mar 11, 2021 · 0 comments
Open

Add RTL support to navigation component #392

Jokinen opened this issue Mar 11, 2021 · 0 comments
Labels
enhancement Request related to a current component/pattern/token/documentation.

Comments

@Jokinen
Copy link
Contributor

Jokinen commented Mar 11, 2021

What

The <Navigation /> component should support right-to-left language direction so it can be used in applications that support languages which are read from right to left (for instance Arabic).

When the <Navigation /> component is used within a HTML document with the dir attribute set to rtl, the <Navigation /> component should offer an UX that's on par with that of a left-to-right language.

Why

In the Jässäri service, we want to add support for various other languages beyond the three defaults. This will make the service more inclusive for people who are most fluent in some other language than Finnish, Swedish or English. This language list contains rtl language(s).

Related material

A quick technical mock with current version using Arabic:
https://codesandbox.io/s/inspiring-sun-x2bih

The current Jässäri page in Munstadi in Arabic:
https://jassari.munstadi.fi/ar/

Link to relevant Jira issue in Jässäri project:
https://helsinkisolutionoffice.atlassian.net/browse/YM-480

Other points

With initial testing we didn't notice issues in other components we made use of. However, I understand that from HDS's perspective this may need to be considered in some other context than this component. Navigation just happened to be the component where we came across the issue.

FYI: The contribution guidelines you link in issue templates does not lead to anywhere: https://hds.hel.fi/contributing

@Jokinen Jokinen added the enhancement Request related to a current component/pattern/token/documentation. label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request related to a current component/pattern/token/documentation.
Projects
None yet
Development

No branches or pull requests

1 participant