Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8018: Fix for TPR Service metatag description #135

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 1, 2023

UHF-8018

What was done

  • Add token for TPR Service description so that it can be used for metatag description

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the helfi_tpr
    • composer require drupal/helfi_platform_config:dev-UHF-8018_tpr_service_metatag_description_fix
  • Run make drush-cr

How to test

  • Go to TPR service page and using the browser inspector make sure that the metatag description of any TPR service with a description has it written on the head-tag. For example like this: <meta name="description" content="Kaupungin lähellä oleva luonto, laajat puistot ja metsät ovat kaikkien vapaasti käytettävissä erilaisiin vapaa-ajan harrasteisiin.">
  • Check that code follows our standards

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #135 (31fa89a) into main (922bdb0) will not change coverage.
The diff coverage is n/a.

❗ Current head 31fa89a differs from pull request most recent head a577395. Consider uploading reports for the commit a577395 to get more accurate results

@@           Coverage Diff           @@
##              main    #135   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
  Complexity       1       1           
=======================================
  Files            1       1           
  Lines            2       2           
=======================================
  Misses           2       2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants