[minor_changes] Added L3Out Argument at site external EPG module #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 66.85% 60.84% -6.02%
==========================================
Files 72 33 -39
Lines 6104 2914 -3190
Branches 1590 753 -837
==========================================
- Hits 4081 1773 -2308
+ Misses 1680 850 -830
+ Partials 343 291 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anvitha-jain
requested review from
lhercot,
shrsr,
akinross,
sajagana,
samiib and
gmicol
akinross
requested changes
Dec 20, 2023
akinross
requested changes
Dec 22, 2023
shrsr
requested changes
Dec 22, 2023
|
Can you also rebase? |
anvitha-jain
force-pushed
the
site_ext_epg
branch
from
0cb8a57 to
4829814
Compare
…te and l3out_schema to compensate.
samiib
reviewed
Jan 9, 2024
shrsr
requested changes
Jan 10, 2024
anvitha-jain
force-pushed
the
site_ext_epg
branch
from
4829814 to
6321179
Compare
akinross
requested changes
Jan 15, 2024
anvitha-jain
force-pushed
the
site_ext_epg
branch
from
6321179 to
1c41952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #383
Associating L3Out created in different templates is only possible in site external EPGs created in NDO version < 4.0.