Collection does not declare its dependency cisco.nd, which also is not part of the Ansible community distribution

[felixfontein]

Description

While working on ansible/ansible#83530 I noticde that I cannot run sanity tests for this collection without installing cisco.nd, since the Python code for many (maybe all?) modules in this collection does not work without that collection installed.

cisco.nd is not declared as a dependency of cisco.mso (https://github.com/CiscoDevNet/ansible-mso/blob/master/galaxy.yml#L24), and besides that cisco.mso cannot declare that dependency without violating the Ansible collection requirements (https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_requirements.html#collection-dependencies) since cisco.nd is not part of the Ansible community package, while ansible.mso is part of it and thus has to adhere to these requirements.

The dependency on cisco.nd has apparently been added in 03f1412 by adding an import from cisco.nd in plugins/module_utils/mso.py, which has first been contained in release https://github.com/CiscoDevNet/ansible-mso/releases/tag/v2.6.0.

Please remove that import and drop the dependency on cisco.nd as soon as possible, to restore functionality of this collection in the Ansible community package.

Ref: https://forum.ansible.com/t/7039

Affected Module Name(s):

Every module using plugins/module_utils/mso.py, which appears to be every module.

[akinross]

HI @felixfontein,

Thank you for raising the awareness, we will discuss this with the team.

[lhercot]

We have merged the fix and released v2.8.0 which include this fix.