Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing process fails due to bad test #44

Open
KyleTryon opened this issue Sep 27, 2022 · 0 comments
Open

Publishing process fails due to bad test #44

KyleTryon opened this issue Sep 27, 2022 · 0 comments
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels bug Something isn't working

Comments

@KyleTryon
Copy link
Contributor

Orb Version
2.0.0

Describe the bug
During the publishing process, tests are re-ran prior to publish. This triggers different behavior in the integration-test-deploy job from heroku which will push to a tag rather than a branch, in the presence of a branch. Previously we did not use tag based deployments, so this was not a concern.

Since orb tools 11 though, this now means we will attempt to push a tag to our sample project on heroku (which is not this project), which does not exist, causing a failure.

This will block deployments.

To Reproduce

https://app.circleci.com/pipelines/github/CircleCI-Public/heroku-orb/161/workflows/1e70cea6-81cc-4692-a8f2-bbc44c1cbaed/jobs/706

Expected behavior

We may need to suppress this test on publish or find an alternative solution.

Additional context

Requires further investigation.

@KyleTryon KyleTryon added bug Something isn't working backlog Identified as a backlog item, often combined with low-priority and help-wanted labels labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant