Support for AWS ECR public registries

[nonsense]

What would you like to be added

At the moment when I try to authenticate with a public AWS ECR registry, I get the following error:

#!/bin/bash -eo pipefail
# get-login-password returns a password that we pipe to the docker login command
aws ecr get-login-password --region $AWS_REGION --profile default | docker login --username AWS --password-stdin $AWS_ECR_ACCOUNT_URL
Error response from daemon: login attempt to https://**************/v2/ failed with status: 400 Bad Request

I've tried various options for AWS_ECR_ACCOUNT_URL env var, such as public.ecr.aws/xxxxxxxx or public.ecr.aws, but nothing seems to work.

I believe the reason is the use of aws ecr, instead of aws ecr-public, which is suggested by AWS when inspecting the View push comments screen:

aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws/xxxxxxxx

---

Additionally I had to add more permissions to the AWS IAM account policy when switching from Private to Public registry, namely:

                "ecr-public:*",
                "sts:*"

[allanvobraun]

Please, any workarounds?

[brivu]

Hey @allanvobraun,

I'm working on a major refactor of this Orb right now and will include public registry support. It should be done at the end of this week or early next week.

Thanks for letting us know!

Best,
Brian

[allanvobraun]

It will be amazing! It will greatly reduce my setup. I'm currently using the aws cli orb.
If you want help testing let me know.

[brivu]

Hey @allanvobraun!

This issue has been addressed and merged in this PR: #172

Cheers!
Brian