Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Distributed Map in Step Functions Definition #115

Closed
harazdovskiy opened this issue Jan 4, 2023 · 2 comments · Fixed by #116
Closed

Add support for new Distributed Map in Step Functions Definition #115

harazdovskiy opened this issue Jan 4, 2023 · 2 comments · Fixed by #116
Assignees

Comments

@harazdovskiy
Copy link

Is your feature request related to a problem? Please describe.
Wide known serverless-step-functions module depends on asl in this place. As @brycenrogers mentioned here

Note: this does not currently work with validate: true as asl-validator does not yet support this behavior.

I've recently faced a limitation in step function, found out it can be fixed with new functionality however syntax validator (asl-validator) does not support it(

We kindly ask to extend the asl-validator with support of new DISTRIBUTED Map options
Screenshot 2023-01-05 at 01 40 48

Describe the solution you'd like
I guess this file should be updated with new properties that Map supports.
Then I will initiate the serverless-step-functions module to update asl-validate -> now we can deploy step functions with fresh AWS functionality altogether)

Describe alternatives you've considered
Don't think we can avoid updating the asl-validator with new AWS functionality

Additional context
https://docs.aws.amazon.com/step-functions/latest/dg/concepts-inline-vs-distributed-map.html

@massfords massfords self-assigned this Jan 5, 2023
@ChristopheBougere ChristopheBougere linked a pull request Jan 5, 2023 that will close this issue
@ChristopheBougere
Copy link
Owner

@harazdovskiy #116 has been released in v3.1.0, could you give it a try?

@harazdovskiy
Copy link
Author

Big thanks to you guys @massfords, @ChristopheBougere! Tested new asl-validator with latest changes of sls-step function. All tests passed

Before:
Screenshot 2023-01-14 at 21 15 47

With new version
Screenshot 2023-01-14 at 21 16 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants