Elevation fixes for start.ps1 #2913
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scripting it's best to use the full function in Powershell.
- Rollback changes from ChrisTitusTech#2648 - Create Variable for script location. - irm -> Invoke-RestMethod, for Powershell standard coding practices. - iex -> Invoke-Expression, for Powershell standard coding practices.
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were elevation issues after #2648, so I reverted one of the changes associate to building the $script variable. Made a couple other changes to have more consistency and maintain Powershell scripting standards.
Type of Change
Description
Testing
Compiled, hosted on local server, and pulled as if I was pulling winutil from Chris's host.
Impact
It might not be as robust as what @MyDrift-user tried to do. And -Config parameters don't get passed through.
Issue related to PR
Related to PR #2908, while keeping the script in RAM.
Partial Fix of #2812
Additional Information
Strangely, the changes before this partial rollback, worked if the winutil.ps1 was local, but broke as soon as you hosted it through the internet and tried loading it into RAM. Quirk of powershell possible or security measure?
windev.ps1 also has the same issue, but I haven't looked at it yet.
Ignore my older commits, I was testing other things before I rolled back.
Checklist