Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflector returning mirrors that are down #1036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • Bug fix

Description

Add --score 5 to return mirrors that have score less than 5 making sure that most of the returned mirrors are active

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Add --score 5 to return mirrors that have score less than 5 making sure that most of the returned mirrors are active
@@ -316,7 +316,11 @@ echo -ne "
Setting up $iso mirrors for faster downloads
-------------------------------------------------------------------------
"
reflector -a 48 -c "$iso" -f 5 -l 20 --sort rate --save /etc/pacman.d/mirrorlist
reflector -a 48 -c "$iso" --score 5 -f 5 -l 20 --sort rate --save /etc/pacman.d/mirrorlist
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of --score 5 we could also use --completion-percent 100 which makes sure all the packages are available. But score also calculated with (hours delay + average duration + standard deviation) / completion percentage. We can use either one to solve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] If a critical mirror is down, the whole Arch Server Setup fails
1 participant