Switching Material themes messes up IDE settings

[LoganDark]

Summary

Selecting a new theme from the dropdown in Appearance & Behavior > Material Theme messes with settings.

Expected behavior

Syntax highlighting settings & accent color settings stay the same.

Actual behavior

Settings are messed with in 2020.1.2, including accent color settings and syntax highlighting settings.

However, switching to a different theme and back in 2018.3.3 (plugin version 5.3.0.1) does not have this behavior.

Steps to reproduce (if needed)

1. Back up your settings
2. Go to Appearance & Behavior > Material Theme
3. Change Selected Theme to something else

This:

Becomes this:

Since this may be an issue with my specific settings, here is an export of all of my settings: settings.zip

To reproduce with my settings, try to change the theme to Material Darker.

Here is an export of all my settings in 2018.3.3, where switching the themes does not have this issue: settings.zip

Importing these settings into 2020.1.2 causes this issue as well as #1617.

Environment

OS: macOS 10.14.6
Product: CLion 2020.1.2
Plugin version: 5.3.2.1
Plugin configuration: material_theme.xml.2020.1.2.zip

[LoganDark]

Related to #1617

[Monadic-Cat]

Are you creating multiple duplicates of the same issue?

...please don't do that.

[LoganDark]

@Monadic-Cat No. The first issue was closed because of the tone, so I created a new issue without 'the tone'. And these are separate issues, so I created 2 issues.

The first issue is for the theme changing itself to Darcula, and the second one is for theme changes also messing up settings.

Even if the first issue had undesirable tone, these are still bugs that should be reported.

[mallowigi]

I don't really understand this issue. Are you reporting that the color scheme definitions between the 2018 version and the 2020 version are different? It could be, two years is a long time.

In any case you can still save a copy of your 2018.3 scheme and it will appear as untouched in 2020.2

[LoganDark]

No, the color scheme looks fine in 2020.1.2. But thanks to #1617, the theme is Darcula, which is not what I want. Trying to change it to Material Darker causes the color scheme to mess up as shown in the image.

Even if #1617 is a wontfix because upgrade bad, this is definitely some kind of bug since it could bite anyone who tries to switch their theme.

[mallowigi]

Again, it's not a mess up. From what I see in the screenshot, the only difference is that keywords are italic, caret color is orange and the font is not Fira Code. And that's exactly some of the changes in the color schemes that occured during those two years.

[LoganDark]

the font is not Fira Code

hasklig :D

And that's exactly some of the changes in the color schemes that occured during those two years.

Well to be fair Material Darker always had an orange caret. I changed it to blue because I liked the blue better.

Again, it's not a mess up. From what I see in the screenshot, the only difference is that keywords are italic, caret color is orange and the font is not Fira Code.

I guess this is just #1617 then. Since Material thinks the theme is different, it didn't know that it already applied those changes and that they were overridden.

[mallowigi]

But this is troubling. Are you saying that you had a copy of Material Darker with those changes and that these changes did not get propagated from 2018 to 2020 ?

[LoganDark]

@mallowigi I did not copy Material Darker. I just went to change the caret color in the actual caret color settings.

[mallowigi]

Ok so everything is okay then ?

[LoganDark]

Yes, now everything is okay. As long as I don't touch anything. Ever.

To be fair, I don't really do that anyway once I get my IDE looking how I want it, which happened years ago. So since my new IDE looks like the old one, I'm fine now.