Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Edit #45

Open
alexvonme opened this issue Jun 22, 2024 · 5 comments
Open

Support for Edit #45

alexvonme opened this issue Jun 22, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@alexvonme
Copy link

Does the extension support the action to edit from Vale?

I've tried the example given by the lead developer of Vale, but it doesn't trigger the appropriate fix. The Quick Fix option just gives out the No suggestion found message.

I thought this might be a problem with the extension because the screenshot from the developer (which I presume is from Sublime Test) seems to suggest the correct answer yet I haven't been able to get the same Quick Fix option in VSCode. I also tried the other parameters from edit such as trim_right and realized I can't get the correct Quick Fix options for them either. Only No suggestion found.

The extension supports the replace and suggest actions, so I was hoping that it could also support, the admittedly more complicated, edit.

@jdkato
Copy link
Collaborator

jdkato commented Jun 24, 2024

This will be possible once #23 is complete.

@ChrisChinchilla
Copy link
Owner

Yes @alexvonme What @jdkato says is mostly true, I think the extension supported (or supports) some edit actions, but it depends on the style rule as the extension then has to add support for every potential option. So I paused development of those in favour of attempting to work on #23 instead, but that’s taking some time due to all sorts of complications (and work 😅). Getting back to it very soon though.

@ChrisChinchilla ChrisChinchilla added the enhancement New feature or request label Jun 24, 2024
@ccoVeille
Copy link

Thanks for the update @ChrisChinchilla , and thanks for working on LSP, it will help solving issues and will be easier to maintain 🥰

@alexvonme
Copy link
Author

alexvonme commented Jun 24, 2024

@ChrisChinchilla thank you for the detailed answer. I asked in part to confirm that it wasn't an issue specific to my configuration. We'll follow that issue as well.

@ChrisChinchilla
Copy link
Owner

@ccoVeille and @alexvonme By the way, the pre-release version of the extension available in VSCode does use the LSP, but it doesn't do too much else 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants