Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #17

Closed
thernstig opened this issue Nov 29, 2023 · 4 comments · Fixed by #18
Closed

Performance issues #17

thernstig opened this issue Nov 29, 2023 · 4 comments · Fixed by #18

Comments

@thernstig
Copy link

thernstig commented Nov 29, 2023

When editing a markdown file with only 300 lines, if some text is marked with yellow squiggly lines (breaking some Vale rule), and then editing it, it takes takes 3-5 seconds before the yellow squiggly line is removed.

In short it seems the entire procedure to check files takes a long time.

I know there is a vale-lsp written in Rust https://github.com/errata-ai/vale-ls, and from my perspective that should be super-fast in doing the parsing (due to the fact it is written in Rust).

No other linter that scans files far larger than our markdown files is this slow. For example the Python linter Ruff (written in Rust, https://docs.astral.sh/ruff/) lints a file with thousands of lines in a millisecond basically.

Something is wrong "somewhere" but I do not know where in the Vale toolchain.

@ChrisChinchilla
Copy link
Owner

@thernstig As far as I can tell from people using the beta version, the next release out today, should fix a lot of this. Switching to using the language server is on the list, but as that's a reasonable amount of work, it will take me a little more time.

@prologic
Copy link

Just wanted to drop a note in here to say that for very large repos, there appears to be similar performance issues, but in the order of 10s or seconds to minutes.

@ChrisChinchilla
Copy link
Owner

@prologic Have you upgraded to the latest versions? As mentioned? If not, could you please open a new issue with a bit more detail about what you mean by "very large" and preferably some kind of reproducible repo for testing :)

@prologic
Copy link

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants