Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive CPU usage when used with VS Code #722 #13

Closed
1 task done
theletterf opened this issue Oct 31, 2023 · 6 comments
Closed
1 task done

Massive CPU usage when used with VS Code #722 #13

theletterf opened this issue Oct 31, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@theletterf
Copy link

Check for existing issues

  • Completed

Environment

macOS 13.6
VSCode 1.83.1
Vale VSCode extension 0.17.5
Vale 2.29.6

Describe the bug / provide steps to reproduce it

When doing search & replace operations in VS Code, the editor (or the add-on, I'm not sure) seems to spawn several vale processes, which end up consuming all available CPU cycles. See screenshot after performing a dozen search & replaces in an rST repository (without opening the files):

I had to close all the vale processes from the Activity Monitor, after which everything got back to normal. This doesn't seem to happen when editing single files. I wonder if this is an add-on issue, a VS Code issue, or a Vale bug.

@ChrisChinchilla
Copy link
Owner

@theletterf I can reproduce this, but I get nowhere near the kind of CPU activity you experience, and they all quit when done. Still, they shouldn't really trigger at all, I guess.

Can I get a couple more details in case it's relevant…

  • Intel or Apple Silicon?
  • Do they ever self-quit if you leave them?
  • How much memory do you have?
  • How did you install vale?

@ChrisChinchilla ChrisChinchilla self-assigned this Nov 11, 2023
@ChrisChinchilla ChrisChinchilla added the bug Something isn't working label Nov 11, 2023
@ChrisChinchilla ChrisChinchilla added this to the 0.18.0 milestone Nov 11, 2023
@ChrisChinchilla
Copy link
Owner

Scrap that, I've figured out what's doing this.

@ChrisChinchilla
Copy link
Owner

ChrisChinchilla commented Nov 12, 2023

OK @theletterf and @Makki93 There should now be a pre-release version available in the VSCode extension. You might need to uninstall the current version to see it, and then you can select the pre-release from the install dropdown. That part of the VSCode interface is a little new to me. You can switch between versions too. Try that version and let me know if it solves these issues.

@theletterf
Copy link
Author

There's an option that says "Switch to pre-release" (so convenient!). Just did the change, will let you know. So far, it seems snappier!

@ChrisChinchilla
Copy link
Owner

@theletterf and @Makki93 It looks like this is working out I think?

@theletterf
Copy link
Author

It is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants