Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pcntl extension and improve installation of others #9

Merged
merged 5 commits into from
Oct 31, 2020
Merged

Add pcntl extension and improve installation of others #9

merged 5 commits into from
Oct 31, 2020

Commits on Oct 31, 2020

  1. Add pcntl extension (removed from core) 

    The pcntl module is one of several slated [to be moved out of
core](https://wiki.php.net/rfc/unbunle-unmaintained-extensions-php8) in
php8, so it now needs to be installed/enabled manually.

This fixes the "Error: PHP extension pcntl is required for enforcing
time limits" warning that's triggered by ShellCommandBuilder's tests.
    @dshoreman
    dshoreman committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    0b23b17 View commit details
    Browse the repository at this point in the history

  2. Use alpine:php helpers for pcov and tideways 

    This significantly reduces the complexity of extension installation by
utilising the docker-php-ext-* helper scripts provided by the php image.

Those scripts cd to /usr/src/php/ext where all the other core extensions
are kept, so by cloning there we save a lot of directory jumping too.

The -ext-install script will also add the `extension=*` line, so that's
removed from the custom xhprof.ini to avoid duplicate loading warnings.
    @dshoreman
    dshoreman committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    2daa356 View commit details
    Browse the repository at this point in the history

  3. Use variables where possible 

    Updates the application group step to use the variable when adding it to
sudoers to avoid issues if those variables are changed, and makes use of
PHP_INI_DIR which is already set to /usr/local/etc/php in the php image.
    @dshoreman
    dshoreman committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    e145cbd View commit details
    Browse the repository at this point in the history

  4. Use helper scripts for xdebug too 

    Updates the xdebug step similarly to the previous pcov/xhprof steps to
use the docker-php-ext-* scripts for installation. Rather than manually
extracting the archive, we can simply clone the given tag. Since we're
using --depth 1 for all the clones, it won't fetch unecessary history.

Also removes the chmod which doesn't seem to be needed when the dir is
created directly within the container instead of being a volume.
    @dshoreman
    dshoreman committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    7daa513 View commit details
    Browse the repository at this point in the history

  5. Update the port being exposed for xdebug

    @dshoreman
    dshoreman committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    5807e74 View commit details
    Browse the repository at this point in the history