Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @javax/@jakarta-annotations optional #54

Open
Chrimle opened this issue Sep 13, 2024 · 3 comments
Open

Make @javax/@jakarta-annotations optional #54

Chrimle opened this issue Sep 13, 2024 · 3 comments
Assignees
Labels
feat Feature change MAJOR Breaking change, expected to cause issues and require additional attention

Comments

@Chrimle
Copy link
Owner

Chrimle commented Sep 13, 2024

Voice your opinion

Via the poll #202

Is your feature request related to a problem? Please describe.
I don't want these annotations, as I intend to use bean-validation annotations instead. These additional annotations just clutter the record classes.

Describe the solution you'd like
Extract the annotations to a separate .mustache-file, so that I can opt-out of using these annotations.

Describe alternatives you've considered
None.

Additional context
This would be backwards-compatible, right?

@Chrimle Chrimle added the feat Feature change label Sep 13, 2024
@Chrimle Chrimle self-assigned this Sep 13, 2024
@Chrimle
Copy link
Owner Author

Chrimle commented Sep 13, 2024

This would be a major (breaking) change for those that have only imported pojo.mustache.

The how-to-instructions should probably be updated, so that all files are imported, but have a way to opt-out of certain things being generated.

@Chrimle
Copy link
Owner Author

Chrimle commented Sep 13, 2024

So, alternatively, when #50 is enabled (=true), these annotations should be replaced? Not sure what value there is to have "redundant" annotations like this?

@Chrimle
Copy link
Owner Author

Chrimle commented Oct 27, 2024

Vote on this topic here: #202

@Chrimle Chrimle added the MAJOR Breaking change, expected to cause issues and require additional attention label Nov 22, 2024
@Chrimle Chrimle moved this from Backlog to Analyze in openapi-to-java-records-mustache-templates Dec 14, 2024
@Chrimle Chrimle moved this from Analyze to Blocked in openapi-to-java-records-mustache-templates Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature change MAJOR Breaking change, expected to cause issues and require additional attention
Projects
Development

No branches or pull requests

1 participant