-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Item on Select #1164
Comments
It seems like all we would really need here is an event around line 863 in choices.ts to make this happen, right? |
I've been working on a fork which implements this; https://github.com/Xon/Choices.js My fork doesn't have the testing pipeline setup, but in the examples and my own usage it doesn't appear to be hitting noticeable bugs. I've just tagged a release which I believe should be stable; https://github.com/Xon/Choices.js/releases/tag/v11.0.0RC1 |
@Xon this is most excellent. Any specific documentation related to this I need to follow? Just downloaded the zip of the code and will try to install your source code directly. Do I need the images fold? |
@Xon two issues Im seeing:
|
It looks like there is a bug with the I've largely been using |
@Xon let me know when fixed and Ill be happy to continue my testing. Great work so far! |
I believe I've fixed the The new select choice code was something I merged in from an outstanding pull request, and runs into limitations of how Essentially it needs an explicit state machine to control were and how input is being processed and the various UI states it enables/disables. This sadly is something which need more time to be worked on. |
Thanks. Was there an alternative library you considered instead of this you think is worth looking at? |
@noctivityinc I've tagged v11.0.0RC4 which contains bugfixes for various I've been granted merge access to this repo and I'm working through fixing the broken tests and getting the above changes merged in. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Very much so. When an item is not in the select list we need an option to let them add the typed string. This is common practice in things like select2
Describe the solution you'd like
A clear and concise description of what you want to happen.
addItem: true
should be supported forselect
lists and then the addItem event should just accept whatever was entered just like withlist = text
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Adding a new button next to the list, which is a weird UX for people to stop to have to click it
Additional context
Add any other context or screenshots about the feature request here.
If you cant do this easily, at least add support for the No items Found label to trigger an event that we can then use to handle this.
The text was updated successfully, but these errors were encountered: