Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Mode using nextThemes #11

Open
ChiragAgg5k opened this issue Oct 7, 2024 · 8 comments
Open

Add Dark Mode using nextThemes #11

ChiragAgg5k opened this issue Oct 7, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Solve these issues for hacktoberfest multi-assign

Comments

@ChiragAgg5k
Copy link
Owner

The site uses shadcn for styling, which has incredibly easy support for adding dark mode. You can follow the this documentation - https://ui.shadcn.com/docs/dark-mode/next

After adding darkmode, do check -

  1. All text or heading is clearly visible
  2. Add a toggle for switching between light and dark mode (in the horizontal navbar)
  3. The toggle is present in mobile navigation as well

Do attach screenshots of the changes. Good luck and do ask any doubts if any!

@ChiragAgg5k ChiragAgg5k added good first issue Good for newcomers hacktoberfest Solve these issues for hacktoberfest labels Oct 7, 2024
@Sathyan-B
Copy link
Contributor

Could you please assign me? I have experience on this. Thanks.

@ChiragAgg5k
Copy link
Owner Author

@Sathyan-B you are assigned! do let me know if you have any doubts

@Sathyan-B
Copy link
Contributor

@Sathyan-B you are assigned! do let me know if you have any doubts

Hi @ChiragAgg5k, Facing few errors while running the code. Can you share the env file?

@ChiragAgg5k
Copy link
Owner Author

@Sathyan-B You need to add the environment variables mentioned here - https://github.com/ChiragAgg5k/cal-buddy/blob/master/.env.example

Hope that helps!

@Sathyan-B
Copy link
Contributor

@Sathyan-B You need to add the environment variables mentioned here - https://github.com/ChiragAgg5k/cal-buddy/blob/master/.env.example

Hope that helps!

Hi @ChiragAgg5k, I have created a PR. Please check. Add comments for any modifications. Thanks #23

@ChiragAgg5k
Copy link
Owner Author

Screenshot 2024-10-11 at 3 23 12 PM

you need to create something similar to this

@Sathyan-B
Copy link
Contributor

Screenshot 2024-10-13 at 9 32 47 AM Screenshot 2024-10-13 at 9 32 57 AM @ChiragAgg5k Please check now. Let me know your comments.

@ChiragAgg5k
Copy link
Owner Author

@Sathyan-B your PR is having merge conflicts. I will recommend you to create a new PR with these changes. Also try to keep the background grid to be visible in dark mode by adding the required tailwind class using the dark: utility class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Solve these issues for hacktoberfest multi-assign
Projects
None yet
Development

No branches or pull requests

2 participants