Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Enable a couple of clang-tidy checks #8

Open
phako opened this issue Sep 29, 2020 · 1 comment
Open

Idea: Enable a couple of clang-tidy checks #8

phako opened this issue Sep 29, 2020 · 1 comment

Comments

@phako
Copy link
Member

phako commented Sep 29, 2020

Especially readability-magic-numbers seems quite useful.

@mhier
Copy link
Member

mhier commented Sep 29, 2020

+1

But readability-magic-numbers will constantly annoy us e.g. in tests where magic numbers are perfectly fine. Also in formulae we quite often have "magic numbers" like 2 (which is already not allowed by default). This one particularly may be just too strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants