Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cursor Pagination with EFCore #4525

Closed
michaelstaib opened this issue Dec 6, 2021 · 3 comments
Closed

Improve Cursor Pagination with EFCore #4525

michaelstaib opened this issue Dec 6, 2021 · 3 comments
Labels
Area: Data Issue is related to filtering, sorting, pagination or projections 🌶️ hot chocolate 📌 pinned
Milestone
HC-14.x.x

Comments

@michaelstaib
Copy link
Member

michaelstaib commented Dec 6, 2021 •
edited
Loading

Track: dotnet/efcore#26822, dotnet/efcore#17065
@michaelstaib michaelstaib added Area: Data Issue is related to filtering, sorting, pagination or projections 🌶️ hot chocolate 🎉 enhancement labels Dec 6, 2021
@michaelstaib michaelstaib added this to the HC-13.0.0 milestone Dec 6, 2021
@stale stale bot added the ⌛ stale Nothing happened with this issue in quite a while label May 4, 2022
@michaelstaib michaelstaib added 📌 pinned and removed ⌛ stale Nothing happened with this issue in quite a while labels May 4, 2022
@glen-84
Copy link
Collaborator

glen-84 commented Jun 20, 2022

Is this considered blocked, or are the linked issues just nice-to-haves?

Keyset pagination can be implemented without row-value comparison. What is Skip/TakeLast needed for?

@ChilliCream ChilliCream deleted a comment from stale bot Jun 21, 2022
@michaelstaib
Copy link
Member Author

Its not blocked, its on the backlog for 13. If you want to have a go at it you can do. Essentially we need to implement a specific paging provider for EF. @PascalSenn can talk you through it if you want to do a PR.

@michaelstaib michaelstaib modified the milestones: HC-13.0.0, HC-13.1.0 Feb 2, 2023
@michaelstaib michaelstaib modified the milestones: HC-13.1.0, HC-13.0.x Jun 2, 2023
@michaelstaib
Copy link
Member Author

This one was superseded by our new paging implementation that is now in 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Data Issue is related to filtering, sorting, pagination or projections 🌶️ hot chocolate 📌 pinned
Projects
None yet
Milestone
HC-14.x.x
Development

No branches or pull requests
2 participants
@glen-84 @michaelstaib