Move the dont-open-twice logic into the variable-paths component #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefAustin
approved these changes
Oct 29, 2024
ChefAustin
merged commit 86dec91
into
ChefAustin:24315-ui-cmdctrl-+-click-wont-correctly-open-new-tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ChefAustin — I was trying to figure out why your changes didn't seem to have the desired effect on the variables page, and I realized it's because of my old long-dormant and unused code for
goToVariable()!I've moved the same logic into
handleFileClick()andhandleFolderClick()in the variable-paths component, which we use from a few places in the UI. My apologies for leaving this in a difficult to update state in the first place!