Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WebDriver by Puppeteer (#790) #860

Merged
merged 114 commits into from
Oct 8, 2017
Merged

Replace WebDriver by Puppeteer (#790) #860

merged 114 commits into from
Oct 8, 2017

Conversation

huan
Copy link
Member

@huan huan commented Oct 7, 2017

Also related with #513: replaced all the unit test from AVA to TAPE(blue-tape with TypeScript support)

  • Replace PuppetWeb Code to using Puppeteer
  • Replace TAP with TAPE
  • Fix all the unit tests

@huan huan requested a review from lijiarui as a code owner October 7, 2017 06:00
@huan huan requested review from binsee and mukaiu October 8, 2017 10:36
@huan
Copy link
Member Author

huan commented Oct 8, 2017

@binsee @mukaiu This PR will refactor Wechaty from using WebDriver to Chrome Puppeteer, which can help us improve the Stability and Performance hugely.

However, It seems that I had broken the code of Upload Media File part. If you could have a look on this PR when you have time, it will help me a lot. Thanks.

P.S. this PR will merge to the master branch as Wechaty Version v0.10

@huan huan merged commit a8e4c1e into master Oct 8, 2017
@huan huan deleted the puppeteer branch October 30, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant