Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: replace document.domain with location.hostname since front one sometimes lose subdomain name #770

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Fixed: replace document.domain with location.hostname since front one sometimes lose subdomain name #770

merged 1 commit into from
Aug 30, 2017

Conversation

zhenyong
Copy link
Contributor

2017-08-30 11 42 18

@zhenyong zhenyong force-pushed the zhenyong-fixed-hostname branch from 58b661e to 01f301d Compare August 30, 2017 04:05
@huan
Copy link
Member

huan commented Aug 30, 2017

Thanks for catching that!

I searched and find that someone said:

Do not use window.document.domain as it is not supported consistently.
at zeroclipboard/zeroclipboard#535

It seems we should switch to use location.hostname as you purposed.

@huan huan added the bug label Aug 30, 2017
@huan huan merged commit db3c2bb into wechaty:master Aug 30, 2017
@huan huan mentioned this pull request Sep 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenyong @huan