#291 change `throw error` to `return null` #292

lijiarui · 2017-03-02T12:50:45Z

#291
if Contact&Room cannot find, function fnd() return null

huan

doc should also be modified in sync.

lijiarui · 2017-03-11T04:03:10Z

@zixia added jsDoc as you required

huan · 2017-03-11T09:03:14Z

Thanks!

lijiarui · 2017-03-11T09:15:20Z

#291

lijiarui · 2017-03-11T10:38:41Z

After merged this one, the following code doesn't work

example/gist-bot/on-friend.ts(34,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-friend.ts(35,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(40,11): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(46,7): error TS2531: Object is possibly 'null'.

huan · 2017-03-11T10:44:04Z

Then fix it please.

wechaty#291 change throw error to return null

9fd6ca1

huan requested changes Mar 2, 2017

View reviewed changes

Merge branch 'master' of https://github.com/wechaty/wechaty into 291

08a90cc

add jsDoc

fc0b33b

huan merged commit 92800c2 into wechaty:master Mar 11, 2017

lijiarui mentioned this pull request Mar 11, 2017

291 #318

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#291 change `throw error` to `return null` #292

#291 change `throw error` to `return null` #292

lijiarui commented Mar 2, 2017

huan left a comment

lijiarui commented Mar 11, 2017

huan commented Mar 11, 2017

lijiarui commented Mar 11, 2017

lijiarui commented Mar 11, 2017

huan commented Mar 11, 2017

#291 change throw error to return null #292

#291 change throw error to return null #292

Conversation

lijiarui commented Mar 2, 2017

huan left a comment

Choose a reason for hiding this comment

lijiarui commented Mar 11, 2017

huan commented Mar 11, 2017

lijiarui commented Mar 11, 2017

lijiarui commented Mar 11, 2017

huan commented Mar 11, 2017

#291 change `throw error` to `return null` #292

#291 change `throw error` to `return null` #292